Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GLSL_KHR_cooperative_matrix to GL_KHR_... #268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gnl21
Copy link
Contributor

@gnl21 gnl21 commented Nov 21, 2024

The extension name as given in the document is GL_KHR_cooperative_matrix so update the filename to match.

The extension name as given in the document is GL_KHR_cooperative_matrix
so update the filename to match.
@gnl21
Copy link
Contributor Author

gnl21 commented Nov 21, 2024

@jeffbolznv I'm not sure why there's a mix of these GLSL and GL extension names, but I'd like to clean them up if I can. Do you know if the difference here was intentional?

@jeffbolznv
Copy link
Contributor

When we started doing GLSL extensions for Vulkan several extension documents got named with the GLSL prefix, to distinguish them from GLSL-for-OpenGL. I don't have a strong opinion on how the files are named.

@gnl21
Copy link
Contributor Author

gnl21 commented Nov 22, 2024

As things have turned out I think this is now making things less clear rather than more, so I'm going to go ahead with the renaming unless people shout. The extension names themselves don't match the filenames (and we show the extension name in most places), and the convention hasn't been applied consistently (eg. GL_KHR_vulkan_glsl).

@jeffbolznv
Copy link
Contributor

I'm OK with the change. Are you also going to update the links in the Vulkan spec?

@pdaniell-nv pdaniell-nv added the Vulkan Functionality applies to Vulkan API label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vulkan Functionality applies to Vulkan API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants