Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to fix issue 752 #2

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

aqnuep
Copy link
Collaborator

@aqnuep aqnuep commented Aug 21, 2023

Reference output updates for KhronosGroup/KTX-Software#752.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aqnuep aqnuep changed the title Issue 752 Tests to fix issue 752 Aug 21, 2023
@aqnuep
Copy link
Collaborator Author

aqnuep commented Aug 22, 2023

@MarkCallow, please merge this as well, otherwise we don't have the up-to-date CTS in the main branch for KhronosGroup/KTX-Software#753, which you already merged.

In general, you need to merge the CTS changes corresponding to code changes.

@MarkCallow
Copy link
Collaborator

MarkCallow commented Aug 22, 2023 via email

@aqnuep
Copy link
Collaborator Author

aqnuep commented Aug 22, 2023

That's weird. I had the CLA signed already for Khronos repositories. Anyway, I did it again.

@MarkCallow
Copy link
Collaborator

That's weird. I had the CLA signed already for Khronos repositories. Anyway, I did it again.

It seems to be a per repo thing. It is still showing as not signed.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Aug 22, 2023

It seems to be a per repo thing. It is still showing as not signed.

I see. We had a discussion with @outofcontrol a while back when we similarly saw CLA warnings being shown when downstreaming code from one Khronos repository to another. I guess that confirms that this works on a per repo basis, but I believe it shouldn't, as the CLA itself applies to all Khronos repositories. Maybe this is something that's worth looking into Khronos-wide.

@aqnuep
Copy link
Collaborator Author

aqnuep commented Aug 22, 2023

Btw, I signed it on this repo as well, but apparently the status doesn't update.

@MarkCallow MarkCallow merged commit dede2ed into KhronosGroup:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants