Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color-space and documentation related improvements for ktx create #732

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

VaderDev
Copy link
Contributor

@VaderDev VaderDev commented Jul 7, 2023

ktx create: Adding none as an --assign-primaries option (#725)
ktx create: Improve usage string and documentation (#726)
ktx create: Allow non-matching input file metadata with warnings (#728)

Copy link
Collaborator

@MarkCallow MarkCallow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have 2 minor change requests.

tools/ktx/command_create.cpp Outdated Show resolved Hide resolved
tools/ktx/command_create.cpp Outdated Show resolved Hide resolved
@MarkCallow MarkCallow merged commit 8b12216 into KhronosGroup:main Jul 8, 2023
@MarkCallow
Copy link
Collaborator

Thanks for the fixes.

@donmccurdy
Copy link
Contributor

Additions and clarifications look great to me as well – thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants