Add KTX_WERROR config option #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- OFF by default. All build scripts have been modified to pass it through. CI .yml files have not yet been modified to turn it ON to test the default case. - Incidental to the main topic, build_android.sh has been modifed to build either configuration and android_debug.sh deleted. All CMake option help prompts have been made into proper sentences. - Temporarily forces tools to use C++17 to prompt a warning for testing purposes. Will be reverted before this is committed to main.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
OFF by default. All build scripts have been modified to pass it through from the environment or command line. CI .yml files have been modified to turn it ON. Incidental to the main topic * Modify build_android.sh to build either configuration and delete build_android_debug.sh. * Make all CMake option help prompts into proper sentences. * Remove cmake_minimum_required from cmake/cputypetest.cmake to stop warning. - Set FMT_SYSTEM_HEADERS to avoid compiler warnings.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
OFF by default. All build scripts have been modified to pass it through from the environment or command line. CI .yml files have been modified to turn it ON. Incidental to the main topic * Modify build_android.sh to build either configuration and delete build_android_debug.sh. * Make all CMake option help prompts into proper sentences. * Remove cmake_minimum_required from cmake/cputypetest.cmake to stop warning. - Set FMT_SYSTEM_HEADERS to avoid compiler warnings.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
OFF by default. All build scripts have been modified to pass it through from the environment or command line. CI .yml files have been modified to turn it ON. Incidental to the main topic * Modify build_android.sh to build either configuration and delete build_android_debug.sh. * Make all CMake option help prompts into proper sentences. * Remove cmake_minimum_required from cmake/cputypetest.cmake to stop warning. - Set FMT_SYSTEM_HEADERS to avoid compiler warnings.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
OFF by default. All build scripts have been modified to pass it through from the environment or command line. CI .yml files have been modified to turn it ON. Incidental to the main topic * Modify build_android.sh to build either configuration and delete build_android_debug.sh. * Make all CMake option help prompts into proper sentences. * Remove cmake_minimum_required from cmake/cputypetest.cmake to stop warning. - Set FMT_SYSTEM_HEADERS to avoid compiler warnings.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
OFF by default. All build scripts have been modified to pass it through from the environment or command line. CI .yml files have been modified to turn it ON. Incidental to the main topic * Modify build_android.sh to build either configuration and delete build_android_debug.sh. * Make all CMake option help prompts into proper sentences. * Remove cmake_minimum_required from cmake/cputypetest.cmake to stop warning. - Set FMT_SYSTEM_HEADERS to avoid compiler warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OFF by default. To be set only when really needed such as in CI.
Fixes #737 and the warning mentioned in PR #743.