Fix legacy app input from pipes on Windows. #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was an unnoticed problem until Cygwin/MSYS2/Git for Windows started mimicing windows pipes in 3.4.x.
to make them available to all legacy apps.
MarkCallow
changed the title
MarkCallow
added a commit
that referenced
this pull request
Aug 22, 2023
Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicing the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. * Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined.
MarkCallow
added a commit
that referenced
this pull request
Sep 4, 2023
Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicing the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. * Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 21, 2024
Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicing the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. * Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicing the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. * Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicing the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. * Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicing the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. * Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
Was always broken for pipes created by Windows' shells (PowerShell and Command). Became broken in cygwin 3.4.x for pipes created by cygwin/MSYS2/Git for Windows shells when cygwin started mimicing the way Windows shells create pipes. The cause is that setting the `FILE_SYNCHRONOUS_IO_NONALERT` option when creating a pipe causes `cin.seekg(0)` on the pipe to return success when in fact seek is not supported. * Add launchDebugger function and --ld option to invoke it to `ktxApp` class and ktx tool as helpers for debugging pipes on Windows. These are only added when _WIN32 and DEBUG are defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was an unnoticed problem until Cygwin/MSYS2/Git for Windows started mimicing windows pipes in 3.4.x.