Do target_type changes only in toktx #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with parts of ktxtools/utility.h useful in imageio. Move image.hpp to imageio.
Document supported conversions in each plug-in and check unsupported conversions are not being requested.
For lib, unittests and toktx, the last 2 of which were suffering from glm warnings.
Why it failed there yet built fine on macOS/g++13, I have no idea.
MarkCallow
added a commit
that referenced
this pull request
Sep 4, 2023
They were being done in both `toktx` and the `imageinput` plugin. Fixes #727. * Move image-related utilities and image.hpp from `ktxtools` to `imageio` target for sharing between new and legacy tools. * Change `toktx` to use the updated version of image.hpp. * Make `other_Includes` a system include for `imageio` and `unittests`. * Make `toktx` use `imageio`'s INTERFACE includes instead of directly referencing the directories. * Fix mismatched `new[]` and `delete` in `glloadtests`.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
They were being done in both `toktx` and the `imageinput` plugin. Fixes KhronosGroup#727. * Move image-related utilities and image.hpp from `ktxtools` to `imageio` target for sharing between new and legacy tools. * Change `toktx` to use the updated version of image.hpp. * Make `other_Includes` a system include for `imageio` and `unittests`. * Make `toktx` use `imageio`'s INTERFACE includes instead of directly referencing the directories. * Fix mismatched `new[]` and `delete` in `glloadtests`.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
They were being done in both `toktx` and the `imageinput` plugin. Fixes KhronosGroup#727. * Move image-related utilities and image.hpp from `ktxtools` to `imageio` target for sharing between new and legacy tools. * Change `toktx` to use the updated version of image.hpp. * Make `other_Includes` a system include for `imageio` and `unittests`. * Make `toktx` use `imageio`'s INTERFACE includes instead of directly referencing the directories. * Fix mismatched `new[]` and `delete` in `glloadtests`.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
They were being done in both `toktx` and the `imageinput` plugin. Fixes KhronosGroup#727. * Move image-related utilities and image.hpp from `ktxtools` to `imageio` target for sharing between new and legacy tools. * Change `toktx` to use the updated version of image.hpp. * Make `other_Includes` a system include for `imageio` and `unittests`. * Make `toktx` use `imageio`'s INTERFACE includes instead of directly referencing the directories. * Fix mismatched `new[]` and `delete` in `glloadtests`.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
They were being done in both `toktx` and the `imageinput` plugin. Fixes KhronosGroup#727. * Move image-related utilities and image.hpp from `ktxtools` to `imageio` target for sharing between new and legacy tools. * Change `toktx` to use the updated version of image.hpp. * Make `other_Includes` a system include for `imageio` and `unittests`. * Make `toktx` use `imageio`'s INTERFACE includes instead of directly referencing the directories. * Fix mismatched `new[]` and `delete` in `glloadtests`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were being done in both
toktxand theimageinputplugin.Fixes #727.
ktxtoolstoimageiotarget for sharingbetween new and legacy tools.
toktxto use the updated version of image.hpp.other_Includesa system include forimageioandunittests.toktxuseimageio's INTERFACE includes instead of directly referencing the directories.new[]anddeleteinglloadtests.