-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encode astc support #952
Encode astc support #952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wasimabbas-arm. Can you now get metrics for ASTC compressed files?
You will need to add tests of the new functionality to the tools CTS and possibly need to update some existing tests.
8f4b5a6
to
eb9ce30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits.
I've merged the CTS changes. They only update some messages. Please add tests that use encode to encode KTX2 files to ASTC. |
@MarkCallow thanks. I will make the rest of the changes. Can I just ask. I know you have mentioned
But every time I have come back to this PR I wasn't sure how many things needs doing (apart from fixing those tests of course). And thats put me off a bit, and ended up procrastinating. Is there a complete list of things that I need to do for this? I am hoping to go through all at once to reduce lots of back and forth. At the moment I have
|
That only modifies 2 golden files to account for the changes in the text of some messages. We need to test the functionality of encoding to ASTC with I'll address the rest of the questions in your comment tomorrow. It's late here now. |
Not sure if the last commit is correct or not. Maybe I need to wait for the KhronosGroup/KTX-Software-CTS#33 to be merged before I can update the submodule |
If you updated the submodule reference to the commit that is in the PR, it should be fine. |
Sorry. It's two days later. Back to your questions.
I was asking if you had implemented the feature of printing metrics on the loss from the encoding. Looking at the code, you seem to have done so. The important thing is decoding the ASTC-compressed images so they can be compared with the reference images. You've done that. The rest of the code in metrics_utils.h is the same regardless whether the images came from BasisU or ASTC encoding. We need tests though. Please add tests that encode to ASTC and print out the metrics. (It is possible you have done so and I missed them when reviewing the CTS PR.)
At the moment I do not think there is anything else beyond addressing the issues here and in the CTS PR. I'll review the docs again but what I looked at so far seemed fine. |
Please modify |
I just found one more thing that needs to be done. The documentation for |
List to track the requests I've made that aren't comments on existing code.
|
@MarkCallow Please refer to #812. Its currently is still the case that both I would argue this is out of scope for this PR. Lets conclude 812 before we proceed. |
The reuse issue has cleared up on its own. I've no idea what happened. The latest version ran fine for me locally. |
351e1d9
to
c629069
Compare
I agree it is out of scope for this PR. I've pinged Alexey again in #812. My view is normalize should be restored. |
Please update the CTS reference then I can merge this. |
Done. |
Thanks @wasimabbas-arm. |
Updated version of #810.
Since #810 was adding a separate tool. Its easier to start another cleaner PR.
This PR has:
Commit to add --format option and make it exclusive with --codec
Add ASTC support to encode