-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glTF MaterialX Converter integration #7
Conversation
@emackey , This is the PR to add glTF<->MTLX converter support into the Khronos main branch. This is sync'ed against the release of 1.38.8. If this is agreed to be merged after review, I will add a Khronos 1.38.8 tag from which a downloadable release can be created. |
@@ -0,0 +1,225 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a copy of the code I have, with a small tweak since it's not in a new module but just included as part of the MaterialXRender
module.
#define MATERIALX_CGLTF_MaterialHandler_H | ||
|
||
// This line added to original source code to place this into the MaterialX Render module. | ||
#define MX_GLTF_API MX_RENDER_API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple "re-map" from custom module in external repo vs here which is in MaterialXRender
.
|
||
/// @class GltfMaterialHandler | ||
/// Wrapper for handling import / export of materials to / from GLTF files | ||
class MX_GLTF_API GltfMaterialHandler : public MaterialHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If JSON export is added and used for conversion then it can derive from the MaterialHandler
base class as needed.
What aspects of this require work? What is blocking this? |
Hi @fire . I need to work out some logistics for this. |
Summary
MaterialXRender
instead of a separate module.mxgltf.py
MaterialX Viewer
andMaterialX Graph Editor
.Caveats