Add support for extension VK_KHR_synchronization2 #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2023
cdavis5e
requested changes
Sep 19, 2023
- MVKPhysicalDevice add support for VkPhysicalDeviceSynchronization2Features. - Pass sync2 structs to MVKPipelineBarrier, MVKCmdPipelineBarrier, MVKCmdSetEvent, MVKCmdResetEvent, MVKCmdWaitEvents, MVKRenderPass, MVKQueue & MVKQueueSubmission. - Replace use of VkPipelineStageFlags & VkAccessFlags with VkPipelineStageFlags2 & VkAccessFlags2. - Add stage masks to MVKPipelineBarrier, and redefine apply*MemoryBarrier() functions to remove separately passing stage masks. - Add MVKSemaphoreSubmitInfo to track semaphores in MVKQueueSubmission. - Add MVKCommandBufferSubmitInfo to track command buffers in MVKQueueCommandBufferSubmission. - Add MVKSubpassDependency to combine VkSubpassDependency & VkMemoryBarrier2 in MVKRenderPass. - Remove abstract MVKCmdSetResetEvent superclass. - Streamline code in MVKMTLFunction::operator= (unrelated).
billhollings
force-pushed
the
VK_KHR_synchronization2
branch
from
a083bf0 to
6127918
Compare
cdavis5e
approved these changes
Sep 19, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKPhysicalDeviceadd support forVkPhysicalDeviceSynchronization2Features.MVKPipelineBarrier,MVKCmdPipelineBarrier,MVKCmdSetEvent,MVKCmdResetEvent,MVKCmdWaitEvents,MVKRenderPass,MVKQueue&MVKQueueSubmission.VkPipelineStageFlags&VkAccessFlagswithVkPipelineStageFlags2&VkAccessFlags2.MVKPipelineBarrier, and redefineapply*MemoryBarrier()functions to remove separately passing stage masks.MVKSemaphoreSubmitInfoto track semaphores inMVKQueueSubmission.MVKCommandBufferSubmitInfoto track command buffers inMVKQueueCommandBufferSubmission.MVKSubpassDependencyto combineVkSubpassDependency&VkMemoryBarrier2inMVKRenderPass.MVKCmdSetResetEventsuperclass.MVKMTLFunction::operator=(unrelated).Implements issue #1514.