Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add queries for cl_khr_integer_dot_product #137

Merged
merged 1 commit into from
Jun 22, 2021
Merged

add queries for cl_khr_integer_dot_product #137

merged 1 commit into from
Jun 22, 2021

Conversation

bashbaug
Copy link
Contributor

Adds query support for the cl_khr_integer_dot_product extension.

See: KhronosGroup/OpenCL-Docs#627

This PR won't break anything as-is, but it will require the corresponding header changes in order to use these changes.

See: KhronosGroup/OpenCL-Headers#170

@bashbaug bashbaug requested a review from kpet June 21, 2021 21:46
kpet
kpet approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@kpet kpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would be nice to have a test but fine with the PR as is.

@bashbaug bashbaug mentioned this pull request Jun 22, 2021
Open
@bashbaug
Copy link
Contributor Author

Thanks! I filed #138 to track the question of device info queries more broadly.

@bashbaug bashbaug merged commit f7237f3 into KhronosGroup:master Jun 22, 2021
@bashbaug bashbaug deleted the cl_khr_integer_dot_product branch June 22, 2021 15:08
@alycm alycm mentioned this pull request Jun 28, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpet kpet kpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bashbaug @kpet