Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup documentation and some extension handling #196

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

bashbaug
Copy link
Contributor

This is a slightly reduced version of #148: it removes the extension defines for the cl_ext_device_fission and cl_khr_image2d_from_buffer extensions because they do not require significant code restructuring, but leaves the extension defines for cl_khr_il_program and cl_khr_subgroups.

After we get in these changes we can look into improving extension handling in general with a subsequent PR.

Other related improvements:

  • Corrects the documentation for CL_HPP_TARGET_OPENCL_VERSION and CL_HPP_MINIMUM_OPENCL_VERSION.
  • The query for CL_DEVICE_PARENT_DEVICE_EXT should return a cl::Device not a cl_device_id, similar to the query for CL_DEVICE_PARENT_DEVICE.
  • When querying for extension funciton pointers, first call clGetExtensionFunctionAddressForPlatform if compiling for OpenCL 1.2 or newer, then call clGetExtensionFunctionAddress if compiling for pre-OpenCL 1.2.

include/CL/opencl.hpp Outdated Show resolved Hide resolved
@bashbaug bashbaug force-pushed the extension-cleanup branch from a92afcc to afe825f Compare March 14, 2023 20:30
@bashbaug bashbaug force-pushed the extension-cleanup branch from afe825f to faede13 Compare March 16, 2023 17:34
@bashbaug
Copy link
Contributor Author

Merging - this has two separate approvals now.

@bashbaug bashbaug merged commit 6df1bbc into KhronosGroup:main Mar 17, 2023
@bashbaug bashbaug deleted the extension-cleanup branch March 17, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants