remove removed external memory and semaphore extensions #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
approved these changes
Jun 25, 2024
|
Looks like this is still failing, even after merging the latest CI/CD changes from the main branch. The main branch is failing too, though. I'm going to go ahead and merge this because it is causing build failures with the latest headers. We still need to fix the CI issues, though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're removing the
cl_khr_external_memory_dxandcl_khr_external_semaphore_dx_fenceextensions due to lack of implementations and test coverage,so the handle types added by these extensions should also be removed from the C++ headers.See: KhronosGroup/OpenCL-Docs#1160
If we decide to keep the handle types for these extensions in the C++ headers for whatever reason, we should still keep the first commit, which adds the necessary include guards around each of the external memory handle types.
Fixes: KhronosGroup/OpenCL-Headers#255