Corrected test_vulkan to use specific platform/device from harness #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additional corrections: -several warnnings removed -unused or dead code limited in affected procedures -cosmetic modernization
test_conformance/vulkan/test_vulkan_api_consistency_for_1dimages.cpp test_conformance/vulkan/test_vulkan_api_consistency_for_3dimages.cpp
|
This is a nice change, it works for us. The test harness is a good addition. |
bashbaug
reviewed
Dec 17, 2024
Comment on lines
+124
to
+125
| errNum = clGetDeviceInfo(deviceId, CL_DEVICE_UUID_KHR, CL_UUID_SIZE_KHR, | ||
| uuid, nullptr); |
There was a problem hiding this comment.
Do we ever check that the cl_khr_device_uuid extension is supported for these tests?
If not, is it acceptable behavior to throw std::runtime_error? I think it would be better to skip the tests, if cl_khr_device_uuid is a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1926 according to task description