Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for cl_ext_buffer_device_address #2192

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add tests for cl_ext_buffer_device_address #2192

wants to merge 3 commits into from

Conversation

franz
Copy link
Contributor

@franz franz commented Dec 14, 2024

No description provided.

@franz franz force-pushed the cl_ext_buffer_device_address branch from 4ef6c67 to fa80d2c Compare December 14, 2024 21:04
@pjaaskel pjaaskel mentioned this pull request Dec 16, 2024
Open
bashbaug
bashbaug reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the new test registration framework for these tests? It should reduce a bit of the test boilerplate, and then we won't need to switch them over later.

#2151

@bashbaug bashbaug mentioned this pull request Dec 16, 2024
Open
@franz
Copy link
Contributor Author

franz commented Dec 19, 2024

@bashbaug added, based on the device_timer test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franz @bashbaug