Clarify implementation deferal of clUpdateMutableCommandsKHR #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address point 1) of KhronosGroup#1309 by clarifying when an implementation may defer propogating the changes from `clUpdateMutableCommandsKHR`. I belive the only semantic implication of this is the removing the restriction > This is only possible with a command-buffer created with the CL_COMMAND_BUFFER_SIMULTANEOUS_USE_KHR flag, as without this the enqueued command-buffer must complete before any modification occurs. So that implementations without simultaneous use support can still defer.
EwanC
force-pushed
the
cmd-buf_update_deffer
branch
from
be696dc to
8396018
Compare
EwanC
commented
Feb 13, 2025
Comment on lines
+16202
to
+16205
| Implementations may defer some of the work to allow {clUpdateMutableCommandsKHR} | ||
| to return immediately, provided the user observable behavior in subsequent | ||
| command-buffer usage is specification conformant. Deferring work helps keep | ||
| device occupancy high by avoiding blocking in host code. |
There was a problem hiding this comment.
Depending on folks preferences for verbosity this could be shortened further by omitting the following parts
- ", provided the user observable behavior in subsequent command-buffer usage is specification conformant" - This is implicit.
- "Deferring work helps keep device occupancy high by avoiding blocking in host code." - This is the motivation behind the semantic, but not the semantic itself, so removing it wouldn't affect specified behavior.
EwanC
commented
Feb 13, 2025
EwanC
added
the
cl_khr_command_buffer
|
This looks good to us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address point 1) of #1309 by clarifying when an implementation may defer propogating the changes from
clUpdateMutableCommandsKHR.I belive the only semantic implication of this is the removing the restriction
So that implementations without simultaneous use support can still defer.