Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement clGetICDLoaderInfoOCLICD. #188

Merged
merged 8 commits into from
Nov 22, 2022

Conversation

Kerilk
Copy link
Contributor

@Kerilk Kerilk commented Oct 10, 2022

This implements clGetICDLoaderInfoOCLICD as suggested in #182

With this change, clinfo reports:

ICD loader properties
  ICD loader Name                                 Khronos OpenCL ICD Loader
  ICD loader Vendor                               Khronos Group
  ICD loader Version                              3.0.4
  ICD loader Profile                              OpenCL 3.0

If we go ahead with this, the cl_icdl.h file should be moved to the header, and the cl_icdl extension should be properly defined.

I decided to keep the enumeration, rather than use defines as we usually do, because I am unsure of the side effects on big endian architectures. This will cause some headaches when defining the xml extension as I think no other enums are defined.

@Kerilk
Copy link
Contributor Author

Kerilk commented Oct 10, 2022

@bashbaug if we decide to merge this, rebasing #182 on this (or the other way around) should be straightforward.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together - there are a lot of interesting ideas here!

CMakeLists.txt Outdated Show resolved Hide resolved
loader/cl_icdl.h Outdated Show resolved Hide resolved
loader/icd_dispatch.c Outdated Show resolved Hide resolved
loader/icd_dispatch.c Outdated Show resolved Hide resolved
loader/cl_icdl.h Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@Kerilk Kerilk force-pushed the clGetICDLoaderInfoOCLICD branch from 01c9c31 to e657293 Compare November 8, 2022 20:34
@Kerilk
Copy link
Contributor Author

Kerilk commented Nov 8, 2022

GitHub action latest images seem to have been updated, and CI is breaking.

@Kerilk
Copy link
Contributor Author

Kerilk commented Nov 10, 2022

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all of my comments are resolved.

I think this needs a rebase now before merging.

Should we bump the rev number to 3.0.5?

@Kerilk Kerilk force-pushed the clGetICDLoaderInfoOCLICD branch from bfa9ddf to 6f4bf35 Compare November 18, 2022 19:24
@Kerilk
Copy link
Contributor Author

Kerilk commented Nov 18, 2022

@bashbaug I have rebased the code on main, and bumped version number to 3.0.5. Unless we want to do the header integration first, I think it is good to go.

@bashbaug
Copy link
Contributor

Merging as agreed on the November 22 teleconference.

@bashbaug bashbaug merged commit 551a74d into KhronosGroup:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants