-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement clGetICDLoaderInfoOCLICD. #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pulling this together - there are a lot of interesting ideas here!
01c9c31
to
e657293
Compare
GitHub action |
@MathiasMagnus any idea why the MacOS CI fails here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, all of my comments are resolved.
I think this needs a rebase now before merging.
Should we bump the rev number to 3.0.5?
bfa9ddf
to
6f4bf35
Compare
@bashbaug I have rebased the code on main, and bumped version number to 3.0.5. Unless we want to do the header integration first, I think it is good to go. |
Merging as agreed on the November 22 teleconference. |
This implements clGetICDLoaderInfoOCLICD as suggested in #182
With this change,
clinfo
reports:If we go ahead with this, the
cl_icdl.h
file should be moved to the header, and thecl_icdl
extension should be properly defined.I decided to keep the enumeration, rather than use defines as we usually do, because I am unsure of the side effects on big endian architectures. This will cause some headaches when defining the xml extension as I think no other enums are defined.