Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in loader_test. #233

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Kerilk
Copy link
Contributor

@Kerilk Kerilk commented Feb 7, 2024

I was playing with valgrind and found a couple of memory leaks in the loader test, this patch addresses these.

@Kerilk Kerilk requested a review from bashbaug February 7, 2024 23:42
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

I'm a little surprised some of the other test_create_calls() do not require do not require releases also, but this is a definite improvement.

@bashbaug bashbaug merged commit 932d826 into KhronosGroup:main Feb 8, 2024
179 checks passed
@Kerilk
Copy link
Contributor Author

Kerilk commented Feb 9, 2024

I'm a little surprised some of the other test_create_calls() do not require do not require releases also, but this is a definite improvement.

Yes, these are done in the test_release function at the end, that puzzled me too. There are no leaks that valgrind would report that I know of anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants