Binary-compatible fixes #283
Conversation
stohrendorf
commented
Jun 21, 2019
stohrendorf
commented
- Add GL_COLOR_ATTACHMENT* members to DrawBufferMode
- Add GL_RGB32F to InternalFormat
- Add enum CopyImageSubDataTarget, using it for glCopyImageSubData instead of CopyBufferSubDataTarget
- Use DrawBufferMode instead of DrawBufferModeATI for glDrawBuffers
- Use GLenum instead of GLint for glTexImage2D internalformat parameter
|
Mostly this looks OK to me - want to run it by the rest of the working group first - but TexImage2D cannot be GLenum, because in the compatibility profile it accepts the integer values 1-4. |
|
Also I just accepted some other PRs which merged duplicate enum groups and caused some conflicts, so this will need to be rebased. I think if you just revert the TexImage2D change after rebasing, this will be uncontroversial. |
* Add GL_COLOR_ATTACHMENT* members to DrawBufferMode * Add GL_RGB32F to InternalFormat * Add enum CopyImageSubDataTarget, using it for glCopyImageSubData instead of CopyBufferSubDataTarget * Use DrawBufferMode instead of DrawBufferModeATI for glDrawBuffers * Use GLenum instead of GLint for glTexImage2D internalformat parameter
|
Rebased and reverted GLint/GLenum change. |
|
Also includes a few more fixes for enums referencing non-existing constants (missing underscores in names). |
|
@pdaniell-nv if you will sign off on this I'll merge it. The only questionable bit was reverted, so this is just modifying the enum groups and doesn't affect the headers at all. |
|
@oddhack approved to merge. |
