Remove the last of the old kind attributes #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generic name but only one usage, should kind=Clamped be used?
SunSerega
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Sorry, took me a while to get back to this, partially because there were some conflicts with my state of XML.
But now that I looked at them, I found that those conflicts were mistakes on my part, and changes from this PR make more sense.
And everything else here also LGTM.
|
@oddhack can you review this PR, and if you're happy with it, it's approved for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the last stuff that was left in in #534. Basically this PR replaces and removes the last
CheckedFloatandCheckedInt32kinds (as well a few others kinds that where leftovers and never described formally).I thought I had fixed these things but it turned out that I had some +1 year old commits in this branch that I never opened a PR for.
cc @SunSerega
This is a fixed version of #621 with cleaner git history.