-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XR_MNDX_force_feedback_curl #136
Conversation
14da518
to
e9f3b48
Compare
An issue (number 1830) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1830 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, some of the CI isn't set up here that we have internally. You'll want to regularly run make reflow
, and also run the various "check" scripts in the specification folder plus scripts/xml_consistency.py
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Show resolved
Hide resolved
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
Here's the current error list:
If you don't want to rephrase these we can add this to an exception list in xml_consistency.
Got some left over and/or wrong enum values.
yeah just add it.
these are the "rearrange the count before the array".
Think this is just outdated names? |
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
3cdd117
to
0f7ef38
Compare
fa4458e
to
086fc69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh I didn't realize I had a pending review still sitting in limbo here, sorry
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
06e92c8
to
256e68a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and force-pushed, and made some minor fixes. Just a few last items remaining.
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
specification/sources/chapters/extensions/mndx/mndx_force_feedback_curl.adoc
Outdated
Show resolved
Hide resolved
…back_curl.adoc Co-authored-by: Ryan A. Pavlik <ryan.pavlik@gmail.com>
…back_curl.adoc Co-authored-by: Ryan A. Pavlik <ryan.pavlik@gmail.com>
Co-authored-by: Ryan A. Pavlik <ryan.pavlik@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being so responsive!
This introduces
XR_MNDX_force_feedback_curl
- a simple extension to provide force feedback for VR Gloves.