Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing attributes #193

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Conversation

rpavlik
Copy link
Contributor

@rpavlik rpavlik commented May 28, 2020

Building layers on some non-x86 platforms highlighted these were missing. Fixes required for Android to even build the layers on arm-ish things. I'd feel better with a review from somebody with a HoloLens 2 before merging.

@rpavlik rpavlik force-pushed the missing-attributes branch from a3e1eed to b6e1242 Compare August 6, 2020 22:30
@rpavlik rpavlik marked this pull request as ready for review August 6, 2020 22:30
@rpavlik rpavlik force-pushed the missing-attributes branch 2 times, most recently from 0ae8855 to 39537f8 Compare August 7, 2020 19:38
@rpavlik rpavlik force-pushed the missing-attributes branch 2 times, most recently from 0b22138 to 80e9e3f Compare August 11, 2020 16:10
@rpavlik rpavlik requested a review from brycehutchings August 14, 2020 20:48
@rpavlik rpavlik merged commit 63e7a59 into KhronosGroup:master Sep 18, 2020
rpavlik added a commit that referenced this pull request Sep 26, 2020
This release features a number of new ratified KHR extensions, as well
as a new vendor extension.

-   Registry
    -   Add ratified XR_KHR_vulkan_enable2 Khronos extension. (internal
        MR 1627, internal issue 1249, internal issue 1283, internal MR
        1863)
    -   Add ratified XR_KHR_loader_init Khronos extension. (internal MR
        1744)
    -   Add ratified XR_KHR_loader_init_android Khronos extension.
        (internal MR 1744)
    -   Add ratified XR_KHR_composition_layer_equirect2 Khronos
        extension. (internal MR 1746)
    -   Add ratified XR_KHR_composition_layer_color_scale_bias Khronos
        extension. (internal MR 1762)
    -   Add XR_MSFT_controller_model extension. (internal MR 1832)
    -   Add vendor tag LIV for LIV Inc. (internal MR 1896)
    -   Fix structextends attribute of XrHandPoseTypeInfoMSFT.
        (OpenXR-SDK-Source/#207)
    -   schema: Update to permit aliases for commands and struct types.
        (Already supported by tooling.) (internal MR 1627)
-   SDK
    -   cmake: fix openxr_loader target export when installing both
        Release and Debug config on Windows. (OpenXR-SDK-Source/#206)
    -   hello_xr: Support the new XR_KHR_vulkan_enable2 extension.
        (internal MR 1627)
    -   hello_xr: Use the XR_KHR_loader_init_android extension on
        Android. (internal MR 1903)
    -   layers: Fix ARM builds by re-adding function attributes.
        (OpenXR-SDK-Source/#193)
-   Misc
    -   Clean up trailing whitespace, byte-order marks, anda ensure
        trailing newlines. (OpenXR-SDK-Source/#208)
rhabacker pushed a commit to rhabacker/OpenXR-SDK-Source that referenced this pull request Nov 16, 2022
This release features a number of new ratified KHR extensions, as well
as a new vendor extension.

-   Registry
    -   Add ratified XR_KHR_vulkan_enable2 Khronos extension. (internal
        MR 1627, internal issue 1249, internal issue 1283, internal MR
        1863)
    -   Add ratified XR_KHR_loader_init Khronos extension. (internal MR
        1744)
    -   Add ratified XR_KHR_loader_init_android Khronos extension.
        (internal MR 1744)
    -   Add ratified XR_KHR_composition_layer_equirect2 Khronos
        extension. (internal MR 1746)
    -   Add ratified XR_KHR_composition_layer_color_scale_bias Khronos
        extension. (internal MR 1762)
    -   Add XR_MSFT_controller_model extension. (internal MR 1832)
    -   Add vendor tag LIV for LIV Inc. (internal MR 1896)
    -   Fix structextends attribute of XrHandPoseTypeInfoMSFT.
        (OpenXR-SDK-Source/KhronosGroup#207)
    -   schema: Update to permit aliases for commands and struct types.
        (Already supported by tooling.) (internal MR 1627)
-   SDK
    -   cmake: fix openxr_loader target export when installing both
        Release and Debug config on Windows. (OpenXR-SDK-Source/KhronosGroup#206)
    -   hello_xr: Support the new XR_KHR_vulkan_enable2 extension.
        (internal MR 1627)
    -   hello_xr: Use the XR_KHR_loader_init_android extension on
        Android. (internal MR 1903)
    -   layers: Fix ARM builds by re-adding function attributes.
        (OpenXR-SDK-Source/KhronosGroup#193)
-   Misc
    -   Clean up trailing whitespace, byte-order marks, anda ensure
        trailing newlines. (OpenXR-SDK-Source/KhronosGroup#208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants