MSL: Work around internal compiler error from mulhi. #2392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #2385
This introduces a helper function to perform
Op*MulExtended
instructions. The helper takes the following template parameters:OpSMulExtended
can be used with unsigned types but will perform signed multiplication. The inputs are cast to signed to perform correct multiplication, and the results need to be cast back to unsigned afterwards in order to satisfy Metal/C++ rules for initializer list types.Updated the tests for these changes, and the shader in the linked issue now compiles without error.