MSL: added mesh-shader support #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not supported in MSL: gl_CullDistance, gl_PrimitiveShadingRateEXT Fixup type of gl_CullPrimitiveEXT: short -> bool
|
Looking at this locally now. Just going to do minor cleanups, but this is a far more palatable PR than the first one and it can probably land without too much controversy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of old #2074
Also made some changes to make diff smaller and also introduced
SetMeshOutputsEXTwrapper, for sake of code-gen clarity.Only mesh stage, for the sake of code-review. Task will be separated PR.
In tests
taskPayloadSharedEXTis replaced toconst; other than that test-cases are copied from HLSLNote: shader-playground is down today - wasn't able to fully test output.Tested shaders via shader-playground