Add deprecatedVersion
field to annotate phase-out features
#249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current grammar JSON lacks a mechanism to annotate phase-out features that are not currently removed from the specification, which currently include
OpDecorationGroup
,OpGroupDecorate
, andOpGroupMemberDecorate
as in SPIR-V 1.5, Revision 5.This PR introduces a
deprecatedVersion
field to show that such features are not recommended to be emitted and the SPIR-V consumers can decide not to support them, if it's preferred.deprecatedVersion
gives the version of SPIR-V specification, in which a feature is deprecated in any of its revisions. It interacts with existing fieldsversion
andlastVersion
, whereversion
is the first version a feature is supported; andlastVersion
the version a feature is completely removed from the specification. The lifetime of a feature can thus be bound as following:version
<deprecatedVersion
<=lastVersion
.