Fix crash with --spirv-preserve-auxdata and removed function #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SPIRVReader, we erase unused functions pretty late, but we were applying the ExtInst for `--spirv-preserve-auxdata` after that, causing us to try to work on a deleted function which lead to a crash. This isn't a problem for the SPIRVWriter case because the unused function deletion happens way earlier. Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Contributor
Author
|
The in-tree failures do not seem related. |
Contributor
MrSidims
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
SPIRVReader, we erase unused functions pretty late, but we were applying the ExtInst for--spirv-preserve-auxdataafter that, causing us to try to work on a deleted function which lead to a crash.This isn't a problem for the
SPIRVWritercase because the unused function deletion happens way earlier.