Rewrite OpenCL explicit conversion builtins handling #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that builtin is valid mostly by matching the regular expression
|
Please take a look @MrSidims @LU-JOHN @asudarsa @bwlodarcz @VyacheslavLevytskyy |
asudarsa
reviewed
Mar 28, 2024
asudarsa
reviewed
Mar 28, 2024
| std::smatch DestTyMatch; | ||
| if (!std::regex_match(TargetTyName, DestTyMatch, Expr)) | ||
| if (!std::regex_match(ConversionFunc, DestTyMatch, Expr)) | ||
| return; | ||
|
|
||
| // The first sub_match is the whole string; the next |
There was a problem hiding this comment.
This comment might need to be rewritten and also appear before the line defining DestTy?
Thanks
asudarsa
reviewed
Mar 28, 2024
asudarsa
reviewed
Mar 28, 2024
LU-JOHN
reviewed
Mar 28, 2024
|
Test fail reported here: #2467 Thanks |
VyacheslavLevytskyy
approved these changes
Apr 3, 2024
svenvh
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that builtin is valid mostly by matching the regular expression - remove unneeded checks.
This is a follow-up to #2443