Handle constant sized array allocations using no extension #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In LLVM, array allocations might have constant size: ```llvm %array = alloca i32, i64 4, align 4 ``` Represent this kind of allocations using `OpVariable + OpBitcast`. Before this patch, the `SPV_INTEL_variable_length_array` extension was used. Signed-off-by: Victor Perez <victor.perez@codeplay.com>
victor-eds
force-pushed
the
constant-alloca
branch
from
5d2dc97
to
9520b63
Compare
victor-eds
commented
Sep 9, 2024
|
MLIR-based compilers will probably generate this kind of allocations for constant size array allocations as that's what MLIR memory allocation operations lower to. |
|
@MrSidims can I get a review here? |
MrSidims
approved these changes
Sep 9, 2024
|
Failing tests not because of lines I've even touched. |
|
Restarting CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LLVM, array allocations might have constant size:
Represent this kind of allocations using
OpVariable + OpBitcast.Before this patch, the
SPV_INTEL_variable_length_arrayextension was used.