Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

llvm-spirv from text to spv: OpUndef is moved from function #169

Open
echuraev opened this issue Aug 10, 2016 · 0 comments
Open

llvm-spirv from text to spv: OpUndef is moved from function #169

echuraev opened this issue Aug 10, 2016 · 0 comments

Comments

@echuraev
Copy link
Contributor

echuraev commented Aug 10, 2016

llvm-spirv tool moves OpUndef instruction from function to program scope. It is bug in the llvm-spirv tool.
Step to reproduce:

  1. Convert attached spv file to binary (llvm-spirv.exe -to-binary reproducer.spt.txt)
  2. Convert spv file back to text.
  3. Undef will not be in body of function.
    After fixing this bug, please implement LIT test for OpUndef in function.

reproducer.spt.txt

echuraev added a commit to echuraev/SPIRV-LLVM that referenced this issue Aug 10, 2016
LIT test wasn't written because issue KhronosGroup#169
(KhronosGroup#169) affect to it.

I have tested it manually but I don't have time to fix this issue. I'll do
it later and will add LIT test.
yxsamliu pushed a commit that referenced this issue Sep 2, 2016
)

* Implemented possibility use OpUndef in Basic Block in SPIR-V file.

LIT test wasn't written because issue #169
(#169) affect to it.

I have tested it manually but I don't have time to fix this issue. I'll do
it later and will add LIT test.

* Updated fix after comments on github

* Implemented LIT test

* Implemented hand-crafted SPIR-V module included two functions with an undef instruction of the same type
robclark pushed a commit to freedreno/SPIRV-LLVM that referenced this issue Jan 26, 2018
…hronosGroup#170)

* Implemented possibility use OpUndef in Basic Block in SPIR-V file.

LIT test wasn't written because issue KhronosGroup#169
(KhronosGroup#169) affect to it.

I have tested it manually but I don't have time to fix this issue. I'll do
it later and will add LIT test.

* Updated fix after comments on github

* Implemented LIT test

* Implemented hand-crafted SPIR-V module included two functions with an undef instruction of the same type
Hopetech pushed a commit to Hopetech/SPIRV-LLVM-Tools that referenced this issue Feb 23, 2018
…170)

* Implemented possibility use OpUndef in Basic Block in SPIR-V file.

LIT test wasn't written because issue #169
(KhronosGroup/SPIRV-LLVM#169) affect to it.

I have tested it manually but I don't have time to fix this issue. I'll do
it later and will add LIT test.

* Updated fix after comments on github

* Implemented LIT test

* Implemented hand-crafted SPIR-V module included two functions with an undef instruction of the same type
AlexeySotkin pushed a commit to AlexeySotkin/SPIRV-LLVM that referenced this issue Mar 12, 2018
…hronosGroup#170)

* Implemented possibility use OpUndef in Basic Block in SPIR-V file.

LIT test wasn't written because issue KhronosGroup#169
(KhronosGroup#169) affect to it.

I have tested it manually but I don't have time to fix this issue. I'll do
it later and will add LIT test.

* Updated fix after comments on github

* Implemented LIT test

* Implemented hand-crafted SPIR-V module included two functions with an undef instruction of the same type
Hopetech pushed a commit to Hopetech/SPIRV-LLVM-Tools that referenced this issue Mar 22, 2018
…170)

* Implemented possibility use OpUndef in Basic Block in SPIR-V file.

LIT test wasn't written because issue #169
(KhronosGroup/SPIRV-LLVM#169) affect to it.

I have tested it manually but I don't have time to fix this issue. I'll do
it later and will add LIT test.

* Updated fix after comments on github

* Implemented LIT test

* Implemented hand-crafted SPIR-V module included two functions with an undef instruction of the same type
AlexeySotkin pushed a commit to AlexeySotkin/SPIRV-LLVM that referenced this issue Apr 3, 2018
…hronosGroup#170)

* Implemented possibility use OpUndef in Basic Block in SPIR-V file.

LIT test wasn't written because issue KhronosGroup#169
(KhronosGroup#169) affect to it.

I have tested it manually but I don't have time to fix this issue. I'll do
it later and will add LIT test.

* Updated fix after comments on github

* Implemented LIT test

* Implemented hand-crafted SPIR-V module included two functions with an undef instruction of the same type
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant