Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for bazel builds #188

Closed
dnovillo opened this issue Jun 7, 2023 · 2 comments · Fixed by #198
Closed

Remove support for bazel builds #188

dnovillo opened this issue Jun 7, 2023 · 2 comments · Fixed by #198

Comments

@dnovillo
Copy link
Contributor

dnovillo commented Jun 7, 2023

We used to need bazel support at Google, but that is no longer the case. @chaoticbob any concerns with removing it? Are there any downstream users who rely on it?
@chaoticbob
Copy link
Contributor

No concerns on my end. I can't be for sure if downstream users but I suspect bazel users aren't numerous. I think it's safe to remove. We'll take feedback if it turns out to be problematic for someone.

@dnovillo
Copy link
Contributor Author

SG. PR coming up.

dnovillo added a commit to dnovillo/SPIRV-Reflect that referenced this issue Jun 27, 2023
@dnovillo
Remove support for building with Bazel.
b286d78 
This fixes KhronosGroup#188
dnovillo added a commit to dnovillo/SPIRV-Reflect that referenced this issue Jun 27, 2023
@dnovillo
Remove support for building with Bazel.
bf62037 
This fixes KhronosGroup#188
@dnovillo dnovillo mentioned this issue Jun 27, 2023
Merged
@ncesario-lunarg ncesario-lunarg mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for building with Bazel. dnovillo/SPIRV-Reflect
2 participants
@chaoticbob @dnovillo