Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpEntryPoint: shader entry points have void(void) signature #1121

Closed
dneto0 opened this issue Dec 19, 2017 · 0 comments · Fixed by #2542
Closed

OpEntryPoint: shader entry points have void(void) signature #1121

dneto0 opened this issue Dec 19, 2017 · 0 comments · Fixed by #2542
Assignees
@zoddicus
Labels
component:validation

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Dec 19, 2017

Currently we check that it has no arguments. We should also check the return type is void
@zoddicus zoddicus self-assigned this Apr 26, 2019
@zoddicus zoddicus mentioned this issue Apr 26, 2019
Merged
zoddicus added a commit that referenced this issue May 1, 2019
@zoddicus
Remove stale comment (#2542)
a5da68d 
Fixes #1121
afd pushed a commit to afd/SPIRV-Tools that referenced this issue May 14, 2019
@zoddicus @afd
Remove stale comment (KhronosGroup#2542)
25ef392 
Fixes KhronosGroup#1121
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this issue Sep 14, 2024
@zoddicus
Rolling 2 dependencies and updating expectations (KhronosGroup#1121)
469c206 
* Rolling 2 dependencies and updating expectations

Roll third_party/spirv-cross/ 6575e451f..0376576d2 (5 commits)

KhronosGroup/SPIRV-Cross@6575e45...0376576

$ git log 6575e451f..0376576d2 --date=short --no-merges --format='%ad %ae %s'
2020-07-22 tommek Enabling setting a fixed sampleMask in Metal fragment shaders.
2020-02-20 cdavis MSL: Add support for processing more than one patch per workgroup.
2020-07-22 dsinclair Roll GLSLang, SPIRV-Headers and SPIRV-Tools.
2020-07-22 cdavis MSL: Factor creating a uint type into its own method.
2020-07-22 cdavis MSL: Factor a really gnarly condition into its own method.

Created with:
  roll-dep third_party/spirv-cross

Roll third_party/spirv-tools/ 969f028..b63f0e5 (13 commits)

KhronosGroup/SPIRV-Tools@969f028...b63f0e5

$ git log 969f028..b63f0e5 --date=short --no-merges --format='%ad %ae %s'
2020-07-27 rdb Fix SyntaxWarning in Python 3.8 (KhronosGroup#3388)
2020-07-27 bclayton CMake: Enable building with BUILD_SHARED_LIBS=1 (KhronosGroup#3490)
2020-07-27 dneto Avoid operand type range checks (KhronosGroup#3379)
2020-07-27 jaebaek Preserve debug info in scalar replacement pass (KhronosGroup#3461)
2020-07-27 pierremoreau Update OpenCL capabilities validation (KhronosGroup#3149)
2020-07-27 stevenperron build(deps): bump lodash from 4.17.15 to 4.17.19 in /tools/sva (KhronosGroup#3596)
2020-07-27 antonikarp spirv-fuzz: adds TransformationReplaceLoadStoreWithCopyMemory (KhronosGroup#3586)
2020-07-27 jaebaek Preserve OpenCL.DebugInfo.100 through private-to-local pass (KhronosGroup#3571)
2020-07-27 stefanomil spirv-fuzz: Relax type checking for int contants (KhronosGroup#3573)
2020-07-27 stefanomil spirv-fuzz: Generalise transformation access chain (KhronosGroup#3546)
2020-07-27 stefanomil spirv-fuzz: Split blocks starting with OpPhi before trying to outline (KhronosGroup#3581)
2020-07-27 afdx spirv-fuzz: Set message consumer in replayer when shrinking (KhronosGroup#3591)
2020-07-24 vasniktel spirv-fuzz: Don't use default parameters (KhronosGroup#3583)

Created with:
  roll-dep third_party/spirv-tools

* Add in missing expectations update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoddicus zoddicus

Labels
component:validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stale comment
2 participants
@zoddicus @dneto0