Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source env should passed into Optimizer as env, not target #2833

Closed
zoddicus opened this issue Sep 4, 2019 · 0 comments · Fixed by #2834
Closed

Source env should passed into Optimizer as env, not target #2833

zoddicus opened this issue Sep 4, 2019 · 0 comments · Fixed by #2834
Assignees
@zoddicus
Labels
bug
Milestone
WebGPU->Vulkan Tr...

Comments

@zoddicus
Copy link
Contributor

zoddicus commented Sep 4, 2019

This previously has not needed clarification because the target and source envs were the same. For WebGPU->Vulkan and Vulkan->WebGPU this starts becoming significant, and has been incorrectly handled. The existing code that passes in the wrong env should be updated, and the related documentation clarified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoddicus zoddicus

Labels
bug
Projects
None yet
Milestone
WebGPU->Vulkan Transformation
Development

Successfully merging a pull request may close this issue.

For WebGPU<->Vulkan optimization, set correct execution environment
1 participant
@zoddicus