Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle CompositeInsert with no indices in VDCE #2258

Merged
merged 3 commits into from
Jan 2, 2019
Merged

Handle CompositeInsert with no indices in VDCE #2258

merged 3 commits into from
Jan 2, 2019

Conversation

s-perron
Copy link
Collaborator

@s-perron s-perron commented Jan 2, 2019

In the spec, there it nothing that forces an OpCompositeInsert to have
an index, but VDCE assumes there is at least 1 in a couple places.

This commit updates VDCE to handle these cases.

@s-perron
Handle CompositeInsert with no indices in VDCE
130e2c2 
In the spec, there it nothing that forces an OpCompositeInsert to have
an index, but VDCE assumes there is at least 1 in a couple places.

This commit updates VDCE to handle these cases.
@s-perron s-perron self-assigned this Jan 2, 2019
@s-perron s-perron requested a review from dnovillo January 2, 2019 18:05
dnovillo
dnovillo approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@dnovillo dnovillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two optional nits.

source/opt/vector_dce.cpp Outdated Show resolved Hide resolved
source/opt/vector_dce.cpp Outdated Show resolved Hide resolved
@s-perron s-perron added the fuzzer-found-issue A note that an issue was found using a fuzzer tool (e.g. GraphicsFuzz) label Jan 2, 2019
@s-perron s-perron merged commit 9f36c8b into KhronosGroup:master Jan 2, 2019
@s-perron s-perron deleted the cr914756 branch January 21, 2019 16:32
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
@zoddicus
Rolling 5 dependencies and update expectations (KhronosGroup#1081)
6ff0205 
Roll third_party/glslang/ d39b8af..68b2e15 (11 commits)

KhronosGroup/glslang@d39b8af...68b2e15

$ git log d39b8af..68b2e15 --date=short --no-merges --format='%ad %ae %s'
2020-06-09 rharrison Use correct type for var storing returned value (KhronosGroup#2263)
2020-06-09 lryer Fix xfb stride limit issue (KhronosGroup#2088)
2020-06-04 laddoc Add Shared/Std140 SSBO process & top-level array elements related (KhronosGroup#2231)
2020-06-04 apinheiro spirv: Support initializers on uniforms (KhronosGroup#1588)
2020-06-03 47594367+rg3igalia Add SPIR-V capabilities needed for spec constants (KhronosGroup#2199)
2020-06-02 rdb HLSL: Add better diagnostic when using in/out qualifiers in global scope (KhronosGroup#2258)
2020-06-02 rdb HLSL: Recognize POSITION semantic et al in DX9 compatibility mode (KhronosGroup#2255)
2020-06-02 rdb HLSL: fix handling of uniform qualifier in entry point parameters (KhronosGroup#2254)
2020-06-01 40001162+alelenv Add default descriptorset decoration for acceleration structure (KhronosGroup#2257)
2020-06-01 cepheus Update news for header location change and recommendation.
2020-06-02 dj2 Remove install to the SPIRV/ folder. (KhronosGroup#2256)

Roll third_party/googletest/ 859bfe898..4fe018038 (9 commits)

google/googletest@859bfe8...4fe0180

$ git log 859bfe898..4fe018038 --date=short --no-merges --format='%ad %ae %s'
2020-06-04 dmauro Googletest export
2020-06-03 absl-team Googletest export
2020-06-02 absl-team Googletest export
2020-06-01 absl-team Googletest export
2020-03-07 krystian.kuzniarek make UniversalPrinter<std::any> support RTTI
2020-03-07 krystian.kuzniarek specialize UniversalPrinter<> for std::any (without support for RTTI)
2020-03-07 krystian.kuzniarek specialize UniversalPrinter<> for std::optional
2020-03-07 krystian.kuzniarek specialize UniversalPrinter<> for std::variant
2020-03-21 ngompa13 Set the version for the libraries

Roll third_party/re2/ aecba1111..2b25567a8 (2 commits)

google/re2@aecba11...2b25567

$ git log aecba1111..2b25567a8 --date=short --no-merges --format='%ad %ae %s'
2020-06-08 junyer Don't pass `-pthread` when building for WebAssembly.
2020-06-06 junyer Add a clarifying comment about case folding.

Roll third_party/spirv-cross/ d385bf096..92fcd7d2b (7 commits)

KhronosGroup/SPIRV-Cross@d385bf0...92fcd7d

$ git log d385bf096..92fcd7d2b --date=short --no-merges --format='%ad %ae %s'
2020-06-08 post GLSL: Handle the rest of GL_ARB_sparse_texture_clamp.
2020-06-08 post GLSL: Support uint code for sparse residency query.
2020-06-05 post Refactor texture fetch function generation.
2020-06-06 AlexanderMeissner Fix missing switch cases in Y'CbCr conversion
2020-06-04 post GLSL: Implement sparse feedback.
2020-06-04 post MSL: Remove obsolete MSLVertexAttr members.
2020-06-04 post HLSL: Add native support for 16-bit types.

Roll third_party/spirv-tools/ f050cca..7c21372 (6 commits)

KhronosGroup/SPIRV-Tools@f050cca...7c21372

$ git log f050cca..7c21372 --date=short --no-merges --format='%ad %ae %s'
2020-06-05 vasniktel spirv-fuzz: Fix replayer bug (KhronosGroup#3401)
2020-06-05 andreperezmaselco.developer Add value instruction condition (KhronosGroup#3385)
2020-06-05 andreperezmaselco.developer Fix instruction function use (KhronosGroup#3390)
2020-06-05 vasniktel spirv-fuzz: Fix regression (KhronosGroup#3396)
2020-06-04 paulthomson Fix googletest inclusion (KhronosGroup#3398)
2020-06-02 jaebaek Add tests for merge-return debug info preservation (KhronosGroup#3389)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnovillo dnovillo dnovillo approved these changes

Assignees

@s-perron s-perron

Labels
fuzzer-found-issue A note that an issue was found using a fuzzer tool (e.g. GraphicsFuzz)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-perron @dnovillo