linker: Recalculate interface variables #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By resolving extern symbols Entry Points might access variables they hadn't declared before.
s-perron
requested changes
Apr 29, 2022
done |
|
Mhh, it seems like that |
…lidate Without the fix Validate will complain about: "ERROR: 9: Interface variable id <5> is used by entry point 'bar' id <1>, but is not listed as an interface\n %5 = OpVariable %_ptr_Input_v3uint Input\n"
karolherbst
force-pushed
the
fix_linking_interface
branch
from
64aab7a to
0b8c557
Compare
|
did something happened to CI? |
s-perron
approved these changes
May 3, 2022
vettoreldaniele
pushed a commit
to vettoreldaniele/SPIRV-Tools
that referenced
this pull request
May 9, 2022
* linker: Recalculate interface variables By resolving extern symbols Entry Points might access variables they hadn't declared before. * test/linker: add test to verify linked spir-vs importing functions validate Without the fix Validate will complain about: "ERROR: 9: Interface variable id <5> is used by entry point 'bar' id <1>, but is not listed as an interface\n %5 = OpVariable %_ptr_Input_v3uint Input\n"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By resolving extern symbols Entry Points might access variables they hadn't declared before.
Side note: we might want to rename
RemoveUnusedInterfaceVariablesPassas it's not removing variables, but instead recomputing them.