spirv-val: Validate zero product workgroup size #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-baker
requested changes
Sep 19, 2023
spencer-lunarg
commented
Sep 20, 2023
| const spv::ExecutionMode mode = spv::ExecutionMode(inst->word(2)); | ||
| entry_point_data_[entry_point].execution_modes.insert(mode); | ||
|
|
||
| // Save for now since the IDs might have not been parsed yet |
There was a problem hiding this comment.
Still thinking about the change to save execution mode instructions. I'm not so sure about that.
I guess is the issue there is some subtle reason we shouldn't be tracking the Instructions ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved version of #4828
closes #4801
Created a
EntryPointDatareduce number of hash maps with theentry_point_idas the key