Update sampled image validation #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnl21 does this match your memory of the outcome of the telecon? |
s-perron
approved these changes
Sep 9, 2024
gnl21
approved these changes
Sep 9, 2024
Fixes KhronosGroup#5781 * Requires all image operands to match except for depth between operand and result
alan-baker
force-pushed
the
sampled-image-5781
branch
from
4df6552 to
5acbc4d
Compare
| @@ -1005,7 +1005,8 @@ bool IsAllowedSampledImageOperand(spv::Op opcode, ValidationState_t& _) { | |||
|
|
|||
| spv_result_t ValidateSampledImage(ValidationState_t& _, | |||
| const Instruction* inst) { | |||
| if (_.GetIdOpcode(inst->type_id()) != spv::Op::OpTypeSampledImage) { | |||
| auto type_inst = _.FindDef(inst->type_id()); | |||
This was referenced Sep 9, 2024
Keenuts
pushed a commit
to Keenuts/SPIRV-Tools
that referenced
this pull request
Nov 12, 2024
Fixes KhronosGroup#5781 * Requires all image operands to match except for depth between operand and result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5781