Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests for multi_ptr aliases for access::address_space::generic #935

Open
wants to merge 5 commits into
base: SYCL-2020
Choose a base branch
from
Open

Add missing tests for multi_ptr aliases for access::address_space::generic #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e993567
Add missing `multi_ptr` aliases for `access::address_space::generic`
victor-eds Sep 9, 2024
da926f4
Conditionally compile added tests
victor-eds Sep 10, 2024
c851b8a
Fix test
victor-eds Sep 10, 2024
ddaf1a0
Fail tests
victor-eds Sep 10, 2024
cd6bc16
Extend and fix tests
victor-eds Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions tests/multi_ptr/multi_ptr_explicit_conversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,41 @@ void check_pointer_aliases(const std::string &type_name) {
}
}

template <typename T>
void check_generic_pointer_aliases(const std::string& type_name) {
SECTION(sycl_cts::section_name("Check explicit generic pointer aliases")
.with("T", type_name)
.create()) {
// FIXME: Enable when aliases defined in implementations.
#if !SYCL_CTS_COMPILING_WITH_HIPSYCL && !SYCL_CTS_COMPILING_WITH_DPCPP
{
INFO("decorated_generic_ptr");
STATIC_CHECK(
std::is_same_v<
sycl::decorated_generic_ptr<T>,
sycl::multi_ptr<T, sycl::access::address_space::generic_space,
sycl::access::decorated::yes>>);
}
{
INFO("raw_generic_ptr");
STATIC_CHECK(
std::is_same_v<
sycl::raw_generic_ptr<T>,
sycl::multi_ptr<T, sycl::access::address_space::generic_space,
sycl::access::decorated::no>>);
}
#endif //! SYCL_CTS_COMPILING_WITH_HIPSYCL && !SYCL_CTS_COMPILING_WITH_DPCPP
}
}

template <typename T>
class check_generic_ptr_aliases_for_type {
public:
void operator()(const std::string& type_name) {
check_generic_pointer_aliases<T>(type_name);
}
};

template <typename T>
class check_multi_ptr_explicit_convert_for_type {
public:
Expand Down
9 changes: 9 additions & 0 deletions tests/multi_ptr/multi_ptr_explicit_conversions_core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#if SYCL_CTS_ENABLE_FEATURE_SET_FULL

#include "../common/disabled_for_test_case.h"
#include "../common/type_coverage.h"
#include "multi_ptr_common.h"
#include "multi_ptr_explicit_conversions.h"
Expand All @@ -36,6 +37,14 @@ TEST_CASE("multi_ptr explicit conversions. Core types", "[multi_ptr]") {
for_all_types<check_multi_ptr_explicit_convert_for_type>(composite_types);
}

DISABLED_FOR_TEST_CASE(DPCPP, hipSYCL)
("generic_ptr alias. Core types", "[multi_ptr]")({
using namespace multi_ptr_explicit_conversions;
auto types = multi_ptr_common::get_types();
auto composite_types = multi_ptr_common::get_composite_types();
for_all_types<check_generic_ptr_aliases_for_type>(types);
for_all_types<check_generic_ptr_aliases_for_type>(composite_types);
});
} // namespace multi_ptr_explicit_conversions_core

#endif // SYCL_CTS_ENABLE_FEATURE_SET_FULL
7 changes: 7 additions & 0 deletions tests/multi_ptr/multi_ptr_explicit_conversions_fp16.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

#include "multi_ptr_explicit_conversions.h"

#include "../common/disabled_for_test_case.h"

namespace multi_ptr_explicit_conversions_fp16 {

TEST_CASE("multi_ptr explicit conversions. fp16 type", "[multi_ptr]") {
Expand All @@ -39,6 +41,11 @@ TEST_CASE("multi_ptr explicit conversions. fp16 type", "[multi_ptr]") {
check_multi_ptr_explicit_convert_for_type<sycl::half>{}("sycl::half");
}

DISABLED_FOR_TEST_CASE(DPCPP, hipSYCL)
("generic_ptr alias. fp16 type", "[multi_ptr]")({
using namespace multi_ptr_explicit_conversions;
check_generic_ptr_aliases_for_type<sycl::half>{}("sycl::half");
});
} // namespace multi_ptr_explicit_conversions_fp16

#endif // SYCL_CTS_ENABLE_FEATURE_SET_FULL
8 changes: 8 additions & 0 deletions tests/multi_ptr/multi_ptr_explicit_conversions_fp64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

#include "multi_ptr_explicit_conversions.h"

#include "../common/disabled_for_test_case.h"

namespace multi_ptr_explicit_conversions_fp64 {

TEST_CASE("multi_ptr explicit conversions. fp64 type", "[multi_ptr]") {
Expand All @@ -39,6 +41,12 @@ TEST_CASE("multi_ptr explicit conversions. fp64 type", "[multi_ptr]") {
check_multi_ptr_explicit_convert_for_type<double>{}("double");
}

DISABLED_FOR_TEST_CASE(DPCPP, hipSYCL)
("generic_ptr alias. fp64 type", "[multi_ptr]")({
using namespace multi_ptr_explicit_conversions;
check_generic_ptr_aliases_for_type<double>{}("double");
});

} // namespace multi_ptr_explicit_conversions_fp64

#endif // SYCL_CTS_ENABLE_FEATURE_SET_FULL
Loading