Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase math builtin test fragment size #975

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Increase math builtin test fragment size #975

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
624a0ea
Increase math builtin test fragment size
steffenlarsen Oct 29, 2024
a9b5444
Apply suggestions from code review
steffenlarsen Oct 30, 2024
f91640a
Merge branch 'main' into steffen/increase_fragment_size
steffenlarsen Nov 4, 2024
ab795cd
Merge branch 'main' into steffen/increase_fragment_size
steffenlarsen Nov 18, 2024
cb940f9
Merge remote-tracking branch 'upstream/main' into steffen/increase_fr…
steffenlarsen Jan 2, 2025
34c138b
Add SYCL_CTS_MATH_BUILTIN_FRAGMENT_SIZE option
steffenlarsen Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/math_builtin_api/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ foreach(cat ${MATH_CAT_WITH_VARIANT})
FILE_PREFIX "math_builtin_${cat}_${var}"
EXT "cpp"
INPUT "math_builtin.template"
EXTRA_ARGS -test ${cat} -variante ${var} -marray true -fragment-size 150
EXTRA_ARGS -test ${cat} -variante ${var} -marray true -fragment-size 230
DEPENDS ${math_builtin_depends}
)
endforeach()
Expand All @@ -44,7 +44,7 @@ foreach(cat ${MATH_CAT})
FILE_PREFIX "math_builtin_${cat}"
EXT "cpp"
INPUT "math_builtin.template"
EXTRA_ARGS -test ${cat} -marray true -fragment-size 150
EXTRA_ARGS -test ${cat} -marray true -fragment-size 230
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are here, you could factorized out this function or macro and add your PR comment as a code comment. 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steffenlarsen, could you please reply to this request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for missing this! I think I need to look at my email filters.

@keryell, do you mean making the magic number here a CMake option with this default value?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for example, with a description in the option explaining what it does and how it sets some trade-off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the SYCL_CTS_MATH_BUILTIN_FRAGMENT_SIZE CMake option for controlling it. Let me know what you think!

DEPENDS ${math_builtin_depends}
)
endforeach()
Expand Down
Loading