-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update root_group
extension tests to use new query API
#985
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
This PR is done but I've marked it as a draft since it depends on intel/llvm#16051 which hasn't been merged yet. |
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC likely ready for review |
@0x12CC, are you sure there is a dependency? The test passed with the DPC++ compiler w/o intel/llvm#16051. |
The updated test cases use an API that was only added in intel/llvm#16051 so I'm fairly certain that it is a dependency. I'll check that now in my local workspace but it may take some time to setup. I didn't think testing for this PR enabled extension tests. The following output is in the CMake configuration step for the
|
@0x12CC, could you update your branch, please? For some reason, GitHub is not able to check if PR can be merged. |
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
That's really strange. I'm also not able to update the branch using the GitHub UI. I pushed a merge commit from my workspace. |
The
max_num_work_group_sync
current query is an API that was removed from the extension specification. This PR updates the test case to match the new query from sycl_ext_oneapi_launch_queries.