Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update root_group extension tests to use new query API #985

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Nov 14, 2024

The max_num_work_group_sync current query is an API that was removed from the extension specification. This PR updates the test case to match the new query from sycl_ext_oneapi_launch_queries.

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Copy link
Contributor Author

0x12CC commented Nov 14, 2024

This PR is done but I've marked it as a draft since it depends on intel/llvm#16051 which hasn't been merged yet.

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@KornevNikita
Copy link
Contributor

@0x12CC likely ready for review

@0x12CC 0x12CC marked this pull request as ready for review December 11, 2024 16:34
@0x12CC 0x12CC requested a review from a team as a code owner December 11, 2024 16:34
@bader
Copy link
Contributor

bader commented Dec 11, 2024

This PR is done but I've marked it as a draft since it depends on intel/llvm#16051 which hasn't been merged yet.

@0x12CC, are you sure there is a dependency? The test passed with the DPC++ compiler w/o intel/llvm#16051.

@0x12CC
Copy link
Contributor Author

0x12CC commented Dec 11, 2024

This PR is done but I've marked it as a draft since it depends on intel/llvm#16051 which hasn't been merged yet.

@0x12CC, are you sure there is a dependency? The test passed with the DPC++ compiler w/o intel/llvm#16051.

The updated test cases use an API that was only added in intel/llvm#16051 so I'm fairly certain that it is a dependency. I'll check that now in my local workspace but it may take some time to setup.

I didn't think testing for this PR enabled extension tests. The following output is in the CMake configuration step for the SYCL CTS CI / compile-cts (dpcpp, ...) check:

 * SYCL_CTS_ENABLE_EXT_ONEAPI_ROOT_GROUP_TESTS
   Enable extension oneAPI root group tests: OFF

@bader
Copy link
Contributor

bader commented Dec 21, 2024

@0x12CC, could you update your branch, please? For some reason, GitHub is not able to check if PR can be merged.

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC
Copy link
Contributor Author

0x12CC commented Dec 23, 2024

@0x12CC, could you update your branch, please? For some reason, GitHub is not able to check if PR can be merged.

That's really strange. I'm also not able to update the branch using the GitHub UI. I pushed a merge commit from my workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants