Update checks for sycl::info::device::preferred_interop_user_sync and sycl::info::device::profile in device_info test
#992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlueck
approved these changes
Dec 3, 2024
bader
reviewed
Dec 3, 2024
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
I updated code. Could you look at it if it's okay? |
bader
approved these changes
Dec 4, 2024
|
@KhronosGroup/sycl-cts-reviewers, we need one approve from a person not affiliated with Intel. Could you take a look, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on specification https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#_device_information_descriptors
sycl::info::device::preferred_interop_user_syncandsycl::info::device::profileinfo descriptors are supposed to throw an exception when the backend is not OpenCL. This is why checks indevice_info.cppwere modified for these specific info device descriptors.