[SYCL] Address multi_ptr in spec vs intel/llvm mismatches #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmoadeli
commented
Jul 11, 2023
•
mmoadeli
commented
- Remove the 'explicit' keyword from the multi_ptr::operator pointer() function.
- Include a generic space constraint in the multi_ptr::ctor from accessor and accessor(local) to support generic_space.
- Implement the multi_ptr::ctor from local_accessor, including support for generic_space.
- Enable implicit conversion of multi_ptr from accessors with const types.
- Add deduction guides for the deprecated access::target::constant_buffer and access::target::local.
- Implement support for the constant_space specialization of non-legacy multi_ptr.
* Remove explicit from multi_ptr<VoidType>::operator pointer() function. * Add generic soace to constraints of multi_ptr<Legacy>::ctor from accessor and accessor(local) with generic_space. * Add multi_ptr<Legacy>::ctor from local_accessor (including generic_space) * Implicit conversion of multi_ptr from accessors with const types. * Sync spec multi_ptr deduction guides with impl.
mmoadeli
changed the title
mmoadeli
changed the title
mmoadeli
changed the title
keryell
approved these changes
Jul 12, 2023
gmlueck
reviewed
Jul 13, 2023
|
One comment also about the description:
I'd change this part of the description to:
This makes it more clear about what changed. |
AerialMantis
approved these changes
Jul 13, 2023
- Replace access::target::device with target::device in decuction guides - Replace access::decorated::legacy wit access::decorated::no in deduction guide specialised with constant_space. - Use same comments for legacy and non-legacy multi_ptr ctors.
|
thanks @gmlueck @AerialMantis for comments. They are addressed. |
gmlueck
reviewed
Jul 14, 2023
gmlueck
approved these changes
Jul 18, 2023
|
LGTM |
keryell
added a commit
that referenced
this pull request
Sep 10, 2024
[SYCL] Address multi_ptr in spec vs intel/llvm mismatches Remove the 'explicit' keyword from the multi_ptr::operator pointer() function. Include a generic space constraint in the multi_ptr::ctor from accessor and accessor(local) to support generic_space. Implement the multi_ptr::ctor from local_accessor, including support for generic_space. Enable implicit conversion of multi_ptr from accessors with const types. Add deduction guides for the deprecated access::target::constant_buffer and access::target::local. Implement support for the constant_space specialization of non-legacy multi_ptr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.