Only run CTS issue workflow when opening PRs; run on base branch #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out the `pull_request` trigger by default also runs when PRs are updated or re-opened. Change to only run on the `opened` activity.
This allows the workflow to access repository secrets even if the triggering PR originates from a fork. This has some security implications, see the comment within the workflow.
psalz
changed the title
gmlueck
approved these changes
Aug 2, 2024
|
I marked this "editorial" because it does not change the specification. Therefore, I think it could be merged without WG approval. @psalz: I'll wait to hear from you before I merge this. Let me know when you think it is ready. |
Should be good to go! |
|
Merging as editorial |
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Only run CTS issue workflow when opening PRs; run on base branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the
pull_requesttrigger by default also runs when PRs are updated or re-opened. Change to only run on theopenedactivity.Additionally, I forgot that using the
pull_requesttrigger doesn't allow the workflow to access repository secrets when the triggering PR originates from a fork. Thankfully there is apull_request_targettrigger to remedy this, which runs the workflow in the context of the base branch (i.e., changes to the workflow itself aren't executed). This is fine for our use case, as we don't need to access the PR's contents within the workflow.(Side note: I marked this asEdit: I've now limited the workflow to only run when changes are made inside theeditorialto not run the workflow - maybe we need another label for these kinds of infrastructure changes).adocdirectory.