Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device description to new format #601

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Aug 4, 2024

Update the section describing the device class to the new format.

Update the section describing the `device` class to the new format.
adoc/chapters/programming_interface.adoc Show resolved Hide resolved
adoc/chapters/programming_interface.adoc Show resolved Hide resolved
adoc/chapters/programming_interface.adoc Show resolved Hide resolved
the [code]#create_sub_devices()# member function template.
The resulting SYCL [code]#devices# are considered sub devices, and it is valid
A device can be partitioned into multiple devices, by calling the
[code]#device::create_sub_devices# member function template.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be code or api?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[code] is correct. The reason is that there are three different definitions of create_sub_devices: one for "partition equally", one for "partition by counts", and one for "partition by affinity domain". We cannot use [api] here because the tooling wouldn't know which of these three definitions to use as the hyperlink target.

adoc/chapters/programming_interface.adoc Show resolved Hide resolved
@ Constructor @ Description
a@
[source]
.[apititle]#Default constructor#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: is this leading . on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The . Asciidoc syntax adds a title to the [source] block below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I have not read the AsciiDoctor documentation for quite a while...

Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a PR!

@tomdeakin
Copy link
Contributor

WG approved to merge.

@gmlueck gmlueck merged commit a9e6c92 into KhronosGroup:main Oct 3, 2024
3 checks passed
@gmlueck gmlueck deleted the gmlueck/reformat-device branch October 3, 2024 18:26
gmlueck added a commit to gmlueck/SYCL-Docs that referenced this pull request Oct 3, 2024
Cherry pick KhronosGroup#601 from main
(cherry picked from commit a9e6c92)
gmlueck added a commit that referenced this pull request Nov 7, 2024
Update device description to new format

(cherry picked from commit a9e6c92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants