-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update device description to new format #601
Conversation
Update the section describing the `device` class to the new format.
the [code]#create_sub_devices()# member function template. | ||
The resulting SYCL [code]#devices# are considered sub devices, and it is valid | ||
A device can be partitioned into multiple devices, by calling the | ||
[code]#device::create_sub_devices# member function template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be code
or api
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[code]
is correct. The reason is that there are three different definitions of create_sub_devices
: one for "partition equally", one for "partition by counts", and one for "partition by affinity domain". We cannot use [api]
here because the tooling wouldn't know which of these three definitions to use as the hyperlink target.
@ Constructor @ Description | ||
a@ | ||
[source] | ||
.[apititle]#Default constructor# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: is this leading .
on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The .
Asciidoc syntax adds a title to the [source]
block below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. I have not read the AsciiDoctor documentation for quite a while...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a PR!
WG approved to merge. |
Cherry pick KhronosGroup#601 from main (cherry picked from commit a9e6c92)
Update device description to new format (cherry picked from commit a9e6c92)
Update the section describing the
device
class to the new format.