Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten VK_PIPELINE_STAGE_2_ALL_GRAPHICS_BIT descriptions #2209

Closed
wants to merge 1 commit into from

Conversation

krOoze
Copy link
Contributor

@krOoze krOoze commented Sep 3, 2023

No description provided.

@spencer-lunarg
Copy link

so while this is "correct" I am curious what it solves.

It adds an indirect lookup for scripts, which adds complexity and not sure what we gain

If a new STAGE was added, I would hope it was consciously added to where it is used and not have to do the indirect lookup if another current stage is a logical-or of it or not

@krOoze
Copy link
Contributor Author

krOoze commented Sep 7, 2023

  1. As it is, it currently covers almost whole page. That impacts scrollability, readability of this flag soup, and everything.
  2. It is less brittle. If bits are added to the subset bit, then they are automatically included in the superset, rather than having to be manually copy pasted there. (DRY principle)

@spencer-lunarg
Copy link

This was discussed again, the main 2 things are

  1. We already are normally explicit in nature with the spec. We use to do this indirect lookup before Sync2 and decide to expand it when this extension was add (lots of confusing what was all in VK_PIPELINE_STAGE_ALL_TRANSFER_BIT)
  2. I agree it might be a tad less brittle, but considering the rate new graphic stage flags are added, I would hope this type of mistake would be caught in validation layer logic generating this

@krOoze
Copy link
Contributor Author

krOoze commented Sep 23, 2023

Not sure what (1) responds to. Nobody was talking about explicitness. Problem is reading the docs and unnecessary verbosity. This one singular Bit covers one whole page (if not two in PDF), and it is not strictly necessary for it to do so.

(2) is slightly naive, given historical experience with this class of human errors. As they say, hope is not a strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants