Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/correct a couple of optional attributes #2252

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

expipiplus1
Copy link
Contributor

@expipiplus1 expipiplus1 commented Oct 17, 2023

To bring them both in line with other dual-use count parameters, as found in other commands or structs.

To bring it in line with other dual-use count parameters
…ModeCount

This brings it in line with other counter members, such as the one in VkSurfacePresentModeCompatibilityEXT
@expipiplus1 expipiplus1 changed the title Add missing optional attribute to pFaultCount Add/correct a couple of optional attributes Oct 17, 2023
xml/vk.xml Show resolved Hide resolved
@dgkoch dgkoch self-assigned this Oct 18, 2023
Copy link
Contributor

@dgkoch dgkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (both for the NV extension, and for the Vulkan SC change)

@dgkoch dgkoch assigned oddhack and unassigned dgkoch Oct 18, 2023
@dgkoch dgkoch added this to the Signed-off to Merge milestone Oct 18, 2023
@oddhack oddhack merged commit f3f8a5d into KhronosGroup:main Oct 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants