New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC identification for modules support #501

Merged

charles-lunarg merged 1 commit into KhronosGroup:main from mikes-lunarg:cmake_debug

Aug 30, 2024

Contributor

mikes-lunarg commented Aug 30, 2024

Can't use MSVC var because it is also true for clang-cl. Fixes #500.


Fix MSVC identification for modules support

9dade07

Can't use `MSVC` var because it is also true for clang-cl. Fixes KhronosGroup#500.

mikes-lunarg requested a review from charles-lunarg

August 30, 2024 16:51

charles-lunarg approved these changes

View reviewed changes

Contributor

charles-lunarg left a comment

Thank you! I was confused why this started failing, but clang-cl breaking all of the common assumptions is par for the course.

charles-lunarg merged commit c6391a7 into KhronosGroup:main

10 checks passed

mikes-lunarg deleted the cmake_debug branch

August 30, 2024 16:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment