Use correct comment character in marmasm.asm & Add Ninja + MSVC/clang-cl workaround for MARMASM #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround that enables ninja + MSVC/clang-cl support in the loader only applied to MASM, which isn't helpful for MARMASM builds. This workaround did not get added to the build as ninja support was not considered required for release of the ARM SDK. However, other parties have started using the ARM build of the loader and reported the issue, necessitating this fix.
|
CI Vulkan-Loader build queued with queue ID 279988. |
|
CI Vulkan-Loader build # 2750 running. |
|
CI Vulkan-Loader build # 2750 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both fixes are needed to enable Ninja builds of the loader on MSVC.
This issue was brought to my attention by @siukosev who helpfully provided a reproducible that made fixing the bug a breeze.