mlefrancois/rt_reflection #274
Conversation
|
|
There was a problem hiding this comment.
Awesome sample. Thank you very much for contributing this :)
Runs fine on my RTX 2060.
CI is currently failing due to the copyright check. Judging by the CI log you need to update the copyright to 2021 in the CMakeLists.txt of your sample to get all CI stages working.
| { | ||
| int objId = gl_InstanceCustomIndexEXT; | ||
|
|
||
| int mat_idx = mat_index[objId].i[gl_PrimitiveID]; |
There was a problem hiding this comment.
Might seem like objId here and below (materials[objId]) should be surrounded by nonuniformEXT?
There was a problem hiding this comment.
Yes, sorry I missed this while translating.
|
Works fine for me on an RTX 2060 on Windows 10. The readme is a great addition too 👍 |
|
tested and works here. NVidia AMD Linux and Windows. |
|
Hi folks, I'd like to get our final approval on this one so we can release it (been stuck for a few weeks). Please help review if able. Thanks! mcj |
Description
Render a simple scene showing the basics of ray tracing, including reflection and shadow rays. The sample creates some geometries and create a bottom acceleration structure for each, then make instances of those, using different materials and placing them at different locations.
Test Environment
General Checklist:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: