Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offline compilation for HLSL shaders with usage of DXC #990

Merged

Conversation

Seweryn-Zielas-Mobica
Copy link
Contributor

Description

Add offline compilation for HLSL with usage of DXC that is bundled with Vulkan SDK.
HLSL shaders will be compiled only if DXC executable is found/provided, otherwise compilation will go as before, without any interruptions.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

CMakeLists.txt Outdated Show resolved Hide resolved
bldsys/cmake/sample_helper.cmake Outdated Show resolved Hide resolved
bldsys/cmake/sample_helper.cmake Outdated Show resolved Hide resolved
bldsys/cmake/sample_helper.cmake Show resolved Hide resolved
Copy link
Collaborator

@SaschaWillems SaschaWillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR. Would love to see this merged as soon as possible :)

Aside from Andreas' comments I only had some minor remarks.

bldsys/cmake/sample_helper.cmake Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
@SaschaWillems SaschaWillems added the hlsl Everything related to getting HLSL support added label Mar 19, 2024
@marty-johnson59 marty-johnson59 merged commit c151341 into KhronosGroup:main Mar 25, 2024
25 checks passed
jeroenbakker-atmind pushed a commit to jeroenbakker-atmind/Vulkan-Samples that referenced this pull request Mar 27, 2024
…oup#990)

* Add offline compilation for HLSL shaders with usage of DXC

* Minor changes related to resolving PR comments.

* Remove message from HLSL shaders compilation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hlsl Everything related to getting HLSL support added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants