-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add offline compilation for HLSL shaders with usage of DXC #990
Merged
marty-johnson59
merged 4 commits into
KhronosGroup:main
from
Mobica:hlsl_shaders_offline_compilation
Mar 25, 2024
Merged
Add offline compilation for HLSL shaders with usage of DXC #990
marty-johnson59
merged 4 commits into
KhronosGroup:main
from
Mobica:hlsl_shaders_offline_compilation
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
SaschaWillems
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this PR. Would love to see this merged as soon as possible :)
Aside from Andreas' comments I only had some minor remarks.
SaschaWillems
approved these changes
Mar 21, 2024
asuessenbach
approved these changes
Mar 25, 2024
12 tasks
jeroenbakker-atmind
pushed a commit
to jeroenbakker-atmind/Vulkan-Samples
that referenced
this pull request
Mar 27, 2024
…oup#990) * Add offline compilation for HLSL shaders with usage of DXC * Minor changes related to resolving PR comments. * Remove message from HLSL shaders compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add offline compilation for HLSL with usage of DXC that is bundled with Vulkan SDK.
HLSL shaders will be compiled only if DXC executable is found/provided, otherwise compilation will go as before, without any interruptions.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: