vulkaninfo: Add video profiles support #1055
Conversation
|
CI Vulkan-Tools build queued with queue ID 314615. |
|
CI Vulkan-Tools build # 1579 running. |
|
CI Vulkan-Tools build # 1579 failed. |
|
The LunarG CI failure is due to an exposure on |
aqnuep
force-pushed
the
rastergrid/video-profiles-support
branch
from
d9a938b to
0169ad3
Compare
|
CI Vulkan-Tools build queued with queue ID 316588. |
|
This is now ready to be reviewed and merged as the Vulkan-Profiles changes are in. |
|
CI Vulkan-Tools build # 1585 running. |
aqnuep
force-pushed
the
rastergrid/video-profiles-support
branch
from
0169ad3 to
8d0dd9b
Compare
|
CI Vulkan-Tools build queued with queue ID 316605. |
|
CI Vulkan-Tools build # 1586 running. |
|
CI Vulkan-Tools build # 1586 passed. |
| # We need to add dumping utilities for enums declared in the video std headers and directly | ||
| # present in the Vulkan API structures. In order to do that we really have no choice but | ||
| # to parse the video.xml and generate the utilities based on the enum types defined there | ||
| videoRegistryFile = self.genOpts.registryFile.replace('vk.xml', 'video.xml') |
There was a problem hiding this comment.
I found I was in a similar pick with the API Dump code gen. I found a way to run the same generator on both vk.xml and video.xml and get useful results. But for vulkaninfo, directly parsing video.xml is definitely preferred due to the architecture and needs of what you are printing.
| flagTypes.add(flagType.name) | ||
|
|
||
| # Utility to get structure definition from structure name | ||
| def GetStructDef(name): |
There was a problem hiding this comment.
Whoops, looks like a design mistake of vulkaninfo requiring a bunch of list iteration instead of using a dictionary. But thats for me to fix in the future, since list iteration works fine when array sizes are low enough.
| ''' | ||
|
|
||
| # Setup video profile info | ||
| out += f'{" " * 20}VkVideoProfileInfoKHR profile_info{{\n' |
There was a problem hiding this comment.
{" " * 20} is a much nicer way of padding! I'll try to remember this trick next time I need to do a lot of that.
This PR accompanies KhronosGroup/Vulkan-Profiles#726 by adding video support to the outputs of
vulkaninfo, including profiles JSON output.This is marked draft for now, because I'd guess we do not want to merge this until the Vulkan-Profiles change is in (and thus the profile JSON schema is updated), but it is otherwise standalone.