Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated synchronization VUIDs #4236

Closed
mikes-lunarg opened this issue Jun 16, 2022 · 0 comments · Fixed by #4246
Closed

Updated synchronization VUIDs #4236

mikes-lunarg opened this issue Jun 16, 2022 · 0 comments · Fixed by #4246
Assignees
@ncesario-lunarg

Comments

@mikes-lunarg
Copy link
Contributor

The 1.3.218 spec relaxed a few sync VUs:

diff --git a/chapters/renderpass.txt b/chapters/renderpass.txt
index 36cf6169..506f7709 100644
--- a/chapters/renderpass.txt
+++ b/chapters/renderpass.txt
@@ -2438,15 +2439,11 @@ include::{chapters}/commonvalidity/stage_mask_common.txt[]
   * [[VUID-VkSubpassDependency-srcSubpass-00865]]
     pname:srcSubpass and pname:dstSubpass must: not both be equal to
     ename:VK_SUBPASS_EXTERNAL
-  * [[VUID-VkSubpassDependency-srcSubpass-00867]]
-    If pname:srcSubpass is equal to pname:dstSubpass and not all of the
-    stages in pname:srcStageMask and pname:dstStageMask are
-    <<synchronization-framebuffer-regions,framebuffer-space stages>>, the
-    <<synchronization-pipeline-stages-order, logically latest>> pipeline
-    stage in pname:srcStageMask must: be
-    <<synchronization-pipeline-stages-order, logically earlier>> than or
-    equal to the <<synchronization-pipeline-stages-order, logically
-    earliest>> pipeline stage in pname:dstStageMask
+  * [[VUID-VkSubpassDependency-srcSubpass-06809]]
+    If pname:srcSubpass is equal to pname:dstSubpass and pname:srcStageMask
+    includes a <<synchronization-framebuffer-regions,framebuffer-space
+    stage>>, pname:dstStageMask must: only contain
+    <<synchronization-framebuffer-regions, framebuffer-space stages>>
   * [[VUID-VkSubpassDependency-srcAccessMask-00868]]
     Any access flag included in pname:srcAccessMask must: be supported by
     one of the pipeline stages in pname:srcStageMask, as specified in the
@@ -4010,15 +4007,11 @@ include::{chapters}/commonvalidity/stage_mask_common.txt[]
   * [[VUID-VkSubpassDependency2-srcSubpass-03085]]
     pname:srcSubpass and pname:dstSubpass must: not both be equal to
     ename:VK_SUBPASS_EXTERNAL
-  * [[VUID-VkSubpassDependency2-srcSubpass-03087]]
-    If pname:srcSubpass is equal to pname:dstSubpass and not all of the
-    stages in pname:srcStageMask and pname:dstStageMask are
-    <<synchronization-framebuffer-regions,framebuffer-space stages>>, the
-    <<synchronization-pipeline-stages-order, logically latest>> pipeline
-    stage in pname:srcStageMask must: be
-    <<synchronization-pipeline-stages-order, logically earlier>> than or
-    equal to the <<synchronization-pipeline-stages-order, logically
-    earliest>> pipeline stage in pname:dstStageMask
+  * [[VUID-VkSubpassDependency2-srcSubpass-06810]]
+    If pname:srcSubpass is equal to pname:dstSubpass and pname:srcStageMask
+    includes a <<synchronization-framebuffer-regions,framebuffer-space
+    stage>>, pname:dstStageMask must: only contain
+    <<synchronization-framebuffer-regions, framebuffer-space stages>>
   * [[VUID-VkSubpassDependency2-srcAccessMask-03088]]
     Any access flag included in pname:srcAccessMask must: be supported by
     one of the pipeline stages in pname:srcStageMask, as specified in the

Spec issue is here: https://gitlab.khronos.org/vulkan/vulkan/-/issues/3075
@mikes-lunarg mikes-lunarg mentioned this issue Jun 16, 2022
Merged
@ncesario-lunarg ncesario-lunarg self-assigned this Jun 20, 2022
ncesario-lunarg added a commit to ncesario-lunarg/Vulkan-ValidationLayers that referenced this issue Jun 20, 2022
@ncesario-lunarg
layers: Relax sync VUs in 1.3.218
4ca5b8a 
Rename 00867 to 06809 and 03087 to 06810. This also removes the ordering
restrictions on these VUs.

Closes KhronosGroup#4236.
@ncesario-lunarg ncesario-lunarg mentioned this issue Jun 20, 2022
Merged
ncesario-lunarg added a commit to ncesario-lunarg/Vulkan-ValidationLayers that referenced this issue Jun 20, 2022
@ncesario-lunarg
layers: Relax sync VUs in 1.3.218
c3a4c3a 
Rename 00867 to 06809 and 03087 to 06810. This also removes the ordering
restrictions on these VUs.

Closes KhronosGroup#4236.
ncesario-lunarg added a commit that referenced this issue Jun 20, 2022
@ncesario-lunarg
layers: Relax sync VUs in 1.3.218
9342a26 
Rename 00867 to 06809 and 03087 to 06810. This also removes the ordering
restrictions on these VUs.

Closes #4236.
@Rua Rua mentioned this issue Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncesario-lunarg ncesario-lunarg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

layers: Relax sync VUs in 1.3.218 ncesario-lunarg/Vulkan-ValidationLayers
2 participants
@mikes-lunarg @ncesario-lunarg